Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add btc consolidation logic and new ui components to psbt and batch psbt screens #726

Merged
merged 26 commits into from
Jan 10, 2024
Merged

feat: add btc consolidation logic and new ui components to psbt and batch psbt screens #726

merged 26 commits into from
Jan 10, 2024

Conversation

fedeerbes
Copy link
Contributor

@fedeerbes fedeerbes commented Dec 21, 2023 •
edited
Loading

🔘 PR Type

  • Enhancement

📜 Background

This PR adds the btc consolidation logic and new ui components to psbt and batch psbt screens

Issue Link: #ENG-3393

🔄 Changes

  • Add logic for psbt signing from btc consolidation logic in psbt screen
  • Add new ui components to use new logic psbt screen
  • Add logic and ui in batch psbt screen

Impact:

  • psbt flow
  • batch psbt flow

🖼 Screenshot / 📹 Video

Videos can be found in linear ticket

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@fedeerbes fedeerbes self-assigned this Dec 21, 2023
m-aboelenein
m-aboelenein reviewed Dec 27, 2023
View reviewed changes
src/app/components/confirmBtcTransaction/itemRow/amount.tsx Outdated Show resolved Hide resolved
src/app/components/confirmBtcTransaction/itemRow/amountWithInscriptionSatribute.tsx Outdated Show resolved Hide resolved
src/app/components/confirmBtcTransaction/itemRow/amountWithInscriptionSatribute.tsx Show resolved Hide resolved
src/app/components/confirmBtcTransaction/itemRow/amountWithInscriptionSatribute.tsx Outdated Show resolved Hide resolved
src/app/components/confirmBtcTransaction/itemRow/avatar.tsx Outdated Show resolved Hide resolved
src/app/components/confirmBtcTransaction/itemRow/rareSats.tsx Outdated Show resolved Hide resolved
src/app/components/confirmBtcTransaction/itemRow/rareSats.tsx Outdated Show resolved Hide resolved
src/app/components/confirmBtcTransaction/index.tsx Show resolved Hide resolved
src/app/components/confirmBtcTransaction/utils.ts Outdated Show resolved Hide resolved
src/app/screens/signBatchPsbtRequest/index.tsx Show resolved Hide resolved
@fedeerbes fedeerbes force-pushed the vic/add-consolidation-logic-skeleton branch from f214f45 to fb30da8 Compare December 28, 2023 11:45
m-aboelenein
m-aboelenein previously approved these changes Dec 28, 2023
View reviewed changes
@DuskaT021 DuskaT021 added testing QA testing in progress and removed ready for test labels Dec 28, 2023
@dhriaznov dhriaznov added the enhancement New feature or request label Dec 29, 2023
@fedeerbes
chore: add showContentTypeThumbnail prop to ordinal image component a…
7a46efb 
…nd use it in psbt screens (#737)

* chore: add showContentTypeThumbnail prop to ordinal image component and use it in psbt screens

* chore: remove bold weight
@fedeerbes
Merge branch 'develop' into vic/add-consolidation-logic-skeleton
85a299e
@fedeerbes
chore: update core version to dummy utxo fixes branch
969a08a
@fedeerbes fedeerbes marked this pull request as ready for review January 9, 2024 10:51
m-aboelenein
m-aboelenein previously approved these changes Jan 9, 2024
View reviewed changes
@DuskaT021 DuskaT021 added testing QA testing in progress and removed ready for test labels Jan 9, 2024
@DuskaT021
Copy link
Contributor

left my comments in the thread

@DuskaT021 DuskaT021 added returned Tested by the QA, didn't pass checks and removed testing QA testing in progress labels Jan 9, 2024
@DuskaT021 DuskaT021 added testing QA testing in progress and removed returned Tested by the QA, didn't pass checks labels Jan 10, 2024
@github-actions GitHub Actions
Copy link

Test with build here: https://github.com/secretkeylabs/xverse-web-extension/actions/runs/7474498723

@DuskaT021 DuskaT021 added ready for release and removed testing QA testing in progress labels Jan 10, 2024
@fedeerbes fedeerbes merged commit e38eb59 into develop Jan 10, 2024
5 checks passed
@fedeerbes fedeerbes deleted the vic/add-consolidation-logic-skeleton branch January 10, 2024 13:42
This was referenced Jan 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DuskaT021 DuskaT021 DuskaT021 approved these changes

@dhriaznov dhriaznov Awaiting requested review from dhriaznov

@m-aboelenein m-aboelenein Awaiting requested review from m-aboelenein

Assignees

@fedeerbes fedeerbes

Labels
enhancement New feature or request ready for release release 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fedeerbes @DuskaT021 @m-aboelenein @dhriaznov @victorkirov @abdulhaseeb4239